erigontech / erigontech/erigon

Commitment: combine `witnessComputeCellHashWithStorage` and its ancestor `computeCellHash`

Open
#17,613 2 comments 0 reactions 0 assignees View on GitHub
tech debt reduction
Dominant language
Go
Stars
3.6k
Forks
1.5k
Avg merge
1d 16h
Merged PRs (30d)
455

Description

So `computeCellHash` computes hash depending on cell contents. If the cell is actually a branch node (hashLen > 0) and represent a top branch of storage subtrie, it computes storage root. We need to distinguish this specific case and be able to return non nil storage root along with account cell hash.

- used in witnesses
- when we read from the trie, without that we do not know actual storage root of account cell, we can only catch it during folding.

To reduce this ambiguity optional field would be handy instead of 2 veryyy similar implementations.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.