erigontech / erigontech/erigon

commitment: evaluate `StateReader` implementation cleanup and replacement

Open
#17,556 1 comment 0 reactions 0 assignees View on GitHub
tech debt reduction
Dominant language
Go
Stars
3.6k
Forks
1.5k
Avg merge
1d 16h
Merged PRs (30d)
465

Description

Follow-up for #17531 based on comments there:

1. it should be possible to cleanup/simplify `LimitedHistoryStateReader` implementation according to [this comment](https://github.com/erigontech/erigon/pull/17531#discussion_r2443784004)
2. [another comment](https://github.com/erigontech/erigon/pull/17531#discussion_r2444497839) suggested to discuss if the new `commitmentdb.StateReader` abstraction should be replaced by existing `state.StateReader`

Contributor guide

Open the contributing guide

Research direction

Start with issue #17531 and the two linked pull-request comments, then inspect the current LimitedHistoryStateReader, commitmentdb.StateReader, and state.StateReader implementations. The work is complete when the cleanup and replacement question has a documented decision and the relevant implementation changes are agreed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, blockchain
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.