erigontech / erigontech/erigon

re-visit stage_snapshots preverified logic: it must be white-list instead of black-list to be forward-compatible

Open
#15,589 8 comments 0 reactions 1 assignee Claimed by @sudeepdino008 View on GitHub
UX
Dominant language
Go
Stars
3.6k
Forks
1.5k
Avg merge
1d 15h
Merged PRs (30d)
463

Description

if in future we will release new type of files - it must not be downloaded by old versions by default.
currently:
```
if !syncCfg.KeepExecutionProofs && isStateHistory(p.Name) && strings.Contains(p.Name, kv.CommitmentDomain.String()) {
continue
}
```

cc @anacrolix

SubTasks
- [] turn to white-list state files. Need to define format of white-list: 1. is it per-file-type or per-file 2. How it must interfere with --prune.mode=minimal were we blacklist old files (but not whole type)
-
- [] turn to white-list block files
- [] https://github.com/erigontech/erigon/issues/15942

reviewer: @anacrolix

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.