ericclemmons / ericclemmons/unique-selector

Does not handle elements detached from DOM

Open
#20 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
272
Forks
55
PR merge metrics
No merged PRs in 30d

Description

If an element has already been detached from the DOM, this throws an exception in `testUniqueness`, which assumes that `parentNode` always exists.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the `testUniqueness` function and inspect the path taken when an element has already been detached from the DOM. Reproduce the exception with a detached element, then run the existing test suite. Done means detached elements no longer cause `testUniqueness` to throw.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.