ericclemmons / ericclemmons/grunt-angular-templates

"Append" breaks if target file ends in comment, like for sourcemapping

Open
#173 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
705
Forks
107
PR merge metrics
No merged PRs in 30d

Description

My target file ends in a sourcemapping comment, which causes the "append" option to break because it appends to the comment instead of starting a new line. It looks like this:

```
//# sourceMappingURL=orbs.js.mapangular.module('orbs').run(['$templateCache', function($templateCache) {
```

Instead of this:
```
//# sourceMappingURL=orbs.js.map
angular.module('orbs').run(['$templateCache', function($templateCache) {
```

I propose making "append" always start on a new line to avoid this problem.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.