ergoplatform / ergoplatform/ergo-appkit

Unusable in modular Java projects

Open
#242 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
44
Forks
34
PR merge metrics
No merged PRs in 30d

Description

Since no module-info exists, nor does an Automatic-Module-Name exist in the MANIFEST.MF, the generated name of this library becomes "ergo.appkit.2.12" which is an invalid name because no part of it can start with a number.

Unfortunately, fixing that will not be enough because the dependencies of this library also do not come with a module name and result in invalid names being generated due to the strange library_2.12 format used by Scala.

However, that does not mean that appkit should not have an Automatic-Module-Name. For example, the scala standard library comes with one (scala.library).

The first step to rectifying this problem is to add an Automatic-Module-Name to appkit. It should be named `org.ergoplatform.appkit` in my opinion.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the build configuration that produces the library's MANIFEST.MF and compare it with the existing module metadata, noting that no module-info or Automatic-Module-Name is currently present. Add the requested org.ergoplatform.appkit name and verify the packaged artifact exposes it without changing the dependency issue described.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.