equinor / equinor/webviz-subsurface-components

Enhanced name parsing for Vector Calculator

Open
#442 0 comments 0 reactions 0 assignees View on GitHub
CeeSol enhancement
Dominant language
TypeScript
Stars
49
Forks
45
Avg merge
1d 8h
Merged PRs (30d)
28

Description

Enhanced name parsing for expressions in vector calculator.

**_Two suggestions:_**
- Create external parsing interface for expression name?
- Parsing according to vector selector node structure in React Component?

**_Description of issue:_**
Additional parsing rules for expression name can occur based on usage in Dash plugin. E.g. if expression names are placed in a vector selector in Dash, the names get additional rules due to rules for vector selector node structure.

Vector Calculator does not know of the usage of created expressions, thus additional name rules can be needed - beyond vector selector node structure.

**_Note:_**
Vectors in vector calculator props are "blacklisted", thereby the vector calculator prevent expression names appending to existing vectors.

**_EXAMPLE 1:_**
"Test:A:A:Test" is valid in Vector Calculator, but inaccessible in Dash plugin as "Test:A:A" is existing name in node structure

![image](https://user-images.githubusercontent.com/82032112/124473152-41e50a00-dd9f-11eb-9a46-5dfe0cf10853.png)
![image](https://user-images.githubusercontent.com/82032112/124473211-55907080-dd9f-11eb-9fb3-8c9f69e6c21d.png)

**_EXAMPLE 2:_**
"WOPT:OP_1" is among the vectors in props, and is blacklisted. New expression names cannot append to the existing vector names, and "save" is disabled.

![image](https://user-images.githubusercontent.com/82032112/124474396-c2583a80-dda0-11eb-9138-887e53bd6685.png)

Contributor guide

Open the contributing guide

Research direction

Start by locating the Vector Calculator component and its expression-name parsing, then inspect how the Dash vector-selector node structure consumes those names. Done requires resolving the parsing boundary and handling the two examples involving nested names and blacklisted vectors.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.