equinor / equinor/subscript

Align test data for fmuobs with what is possible to validate

Open
#652 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
21
Forks
34
Avg merge
2d 7h
Merged PRs (30d)
2

Description

Including ert-doc.obs in an ert config file doesn't validate in ert as of January 2024.
Some enquiry done, and at least two things stand out:
* BLOCK_OBSERVATIONs were deprecated sometime in 2022
* Date fields now have to be in iso 8601 format (YYYY-MM-DD)
The tests were not picking this up, because the OBS_CONFIG keyword was not used in testing with ert
In my opinion the test data should validate in ert otherwise it is not a good dataset.
Suggestion is to modify test data accordingly, but to leave the code otherwise as is, for backward compatibility.
This should not cause problems since the changes made to ert are a narrowing down, not a widening up..

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.