equinor / equinor/subscript

Stop using custom logging setup for workflows

Open
#459 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
21
Forks
34
Avg merge
2d 7h
Merged PRs (30d)
2

Description

Using: https://github.com/equinor/subscript/blob/5e159d191f393ef058e29c64f57ad9fbfd6f1156/src/subscript/__init__.py#L12 results in flooding the `stdout` of `ert` when used in workflows where `subscript` is essentially used as a library. In those cases using logging is fine, but `ert` should be responsible for setting up the logger. In those cases the standard logging module should be used directly:

```python
import logging
...
logger = logging.getLogger(__name__)
logger.info("msg")
```
for forward models using the `subscript` logger is fine, because they have their own entry points and is the module in charge of the excution.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.