equinor / equinor/resdata

Support contigous vector of doubles in ecl_sum_data_add_new_tstep()

Open
#811 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
127
Forks
103
Avg merge
2d 5h
Merged PRs (30d)
18

Description

For speed reasons, there should be a version of `ecl_sum_data_add_new_tstep()` that can take a contiguous vector of doubles.

The current code takes one value at a time, and performs index buiding each time. This results in slowness when f.ex. EclSum objects are created from numpy vectors/pandas dataframes.

https://github.com/equinor/ecl/blob/265dd23808f3987c38802b018f361b2fe0f317a6/lib/ecl/ecl_sum_data.cpp#L673-L678

Fixing this might create a possibility for test code that creates EclSum objects on the fly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.