equinor / equinor/res2df

Rename PRTFILE argument to DATAFILE in fipreports

Open
#440 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
37
Forks
38
Avg merge
1h 45m
Merged PRs (30d)
1

Description

In the fipreports submodule the positional argument is PRTFILE, while in all other submodules the positional argument is DATAFILE.
This is inconsistent, and creates some unnecessary code to deal with this fact inside of common and ecl2csv. This is a small change that will not make a lot of difference to the user, but will make the code neater.

Contributor guide

Open the contributing guide

Research direction

Start by locating the positional argument definition in the fipreports submodule, then read the related handling in common and ecl2csv. Rename the argument from PRTFILE to DATAFILE and verify that the surrounding code no longer needs special handling for the inconsistent name.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.