equinor / equinor/res2df

[compdat] * handling in COMPDAT

Open
#336 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
37
Forks
38
Avg merge
1h 45m
Merged PRs (30d)
1

Description

ecl2df is used as part of the Flownet tool (https://github.com/equinor/flownet). We are applying it to an Equinor asset model that contains the following lines in the SCHEDULE section:

COMPDAT
-- WELL I J K1 K2 stat Sat. CF DIAM KH SKIN ND DIR Ro
' * ' 0 0 1 47 'SHUT' 1* 1* 0.152 /
/

(The spaces around the * are not there in the actual file.)

This causes an error that originates from compdat.py, line 130: "WELSPECS must be provided when I is defaulted in COMPDAT" since rec_data["WELL"] in this case is equal to '*' which is not included in the well list called "welspecs".

A solution could be to check if rec_data["WELL"] contains a * and, if so, create a well list that contains all wells that meet the required name format. The check that I and J are specified should then be done for all wells in this list.

Contributor guide

Open the contributing guide

Research direction

Start in compdat.py around line 130 and trace how COMPDAT records resolve WELL values against WELSPECS. Check how a '*' WELL value should select matching wells, then ensure I and J validation is applied to each selected well; done means the shown COMPDAT input parses without the current error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.