equinor / equinor/oneseismic-api

Refactor the go tests in the cmd/query folder

Open
#248 0 comments 0 reactions 1 assignee Claimed by @sveinung-r View on GitHub
Dominant language
C++
Stars
5
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Tests in main_test.go has been expanded to cover new cases as features has been added or changed. Several of the tested features are hosed in endpoint.go or request.go in the api folder. Maybe it would be more natural to move some of these tests to request_tests.go. It could also be considered to create endpoint_test.go if this is structurally beneficial.

It should also be considered if NormalizeConnection can be tested directly and not via an endpoint.

What is the reason for "utils_main_test.go"?
If we deviate from the pattern where "filename_test.go" test functions in "filename.go" it would be beneficial to add a line or two describing the motivation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.