equinor / equinor/fusion-framework
navigation module: remove direct @remix-run/router dependency
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 10
- Avg merge
- 19h 40m
- Merged PRs (30d)
- 150
Description
## Context
`@equinor/fusion-framework-module-navigation` still depends on `@remix-run/router` directly in:
- `packages/modules/navigation/src/NavigationProvider.interface.ts`
- `packages/modules/navigation/src/NavigationProvider.ts`
Both files carry the same TODO:
```ts
// TODO: Remove @remix-run/router dependency once all apps have migrated to @equinor/fusion-framework-react-router
```
## Task
- Confirm all consuming apps/cookbooks have migrated to `@equinor/fusion-framework-react-router`.
- Remove the direct `@remix-run/router` dependency and related types from `NavigationProvider` and its interface, replacing them with the framework's own router abstractions where needed.
- Update the package's `package.json` dependencies accordingly.
## Files
- `packages/modules/navigation/src/NavigationProvider.interface.ts` (line 1)
- `packages/modules/navigation/src/NavigationProvider.ts` (line 1)
Contributor guide
Research direction
Check consuming apps and cookbooks first to confirm they use @equinor/fusion-framework-react-router. Then inspect the TODOs and router types in packages/modules/navigation/src/NavigationProvider.interface.ts and NavigationProvider.ts, followed by the package.json dependencies. Done means the direct @remix-run/router dependency and related types are removed while the navigation module uses the framework router abstractions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100