equinor / equinor/fusion-framework

bookmark: attach updated payload when current bookmark matches updated bookmark

Open
#5,139 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

In `packages/modules/bookmark/src/BookmarkProvider.ts`, the bookmark update success handler has:

```ts
map(
// TODO: add payload if current bookmark is the same as the updated bookmark
({ payload }): Bookmark =>
({
...bookmarkSelector(this.#store.value, payload.id),
payload: payload.payload,
}) as Bookmark,
),
```

Investigate merging/attaching the updated `payload` onto the current bookmark when the updated bookmark is the currently active one, so consumers observing the current bookmark get the fresh payload data immediately.

Contributor guide

Open the contributing guide

Research direction

Read packages/modules/bookmark/src/BookmarkProvider.ts, starting with the bookmark update success handler and bookmarkSelector usage. Trace how the current bookmark is identified and how consumers observe it, then verify that the active bookmark receives the updated payload immediately without changing unrelated bookmarks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.