equinor / equinor/fusion-framework

bookmark: allow disabling child provider onCurrentBookmarkChanged propagation

Open Beginner friendly
#5,138 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

In `packages/modules/bookmark/src/BookmarkProvider.ts`'s constructor, child bookmark provider event subscription has:

```ts
// subscribe to child bookmark provider changes
// TODO - add support for disabling this feature
if (this._event) {
this._event.addEventListener('onCurrentBookmarkChanged', (event) => {
...
```

Add configuration support to opt out of propagating `onCurrentBookmarkChanged` events from a child bookmark provider.

Contributor guide

Open the contributing guide

Research direction

Start in packages/modules/bookmark/src/BookmarkProvider.ts, focusing on the constructor and the child provider onCurrentBookmarkChanged listener. Inspect how constructor configuration is represented, then verify that propagation remains enabled by default and is skipped when the new opt-out setting is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.