equinor / equinor/fusion-framework

bookmark: add deep diff comparison for errors$ observable

Open
#5,137 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

In `packages/modules/bookmark/src/BookmarkProvider.ts`, the `errors$` getter has:

```ts
public get errors$(): Observable> {
// TODO - add deep diff
return this.#store.select(errorsSelector, deepEqual);
}
```

Investigate replacing the current equality check with a deep-diff comparison to avoid unnecessary emissions when errors are structurally equal but not reference-equal.

Contributor guide

Open the contributing guide

Research direction

Start in packages/modules/bookmark/src/BookmarkProvider.ts at the errors$ getter and inspect how errorsSelector and deepEqual are used. Investigate a deep-diff comparison that prevents emissions for structurally equal BookmarkFlowError arrays; done means equivalent error results no longer emit unnecessarily while actual changes still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.