equinor / equinor/fusion-framework

app: remove legacy manifest update-flag handling in create-reducer.ts

Open Beginner friendly
#5,131 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

In `packages/modules/app/src/app/create-reducer.ts`, the `setManifest` reducer case branches on `action.meta.update` to merge vs. replace the manifest, with a note that this is legacy behavior:

```ts
// TODO: after legacy is removed, remove the update flag
if (action.meta.update) {
state.manifest = Object.assign(state.manifest ?? {}, action.payload);
} else {
state.manifest = action.payload;
}
```

Remove the `update` flag branch once the legacy manifest-merge behavior is no longer needed.

Contributor guide

Open the contributing guide

Research direction

Start in packages/modules/app/src/app/create-reducer.ts at the setManifest reducer case, then search the app module for references to action.meta.update and the legacy merge behavior. Done means the obsolete update-flag branch and its remaining references are removed without changing the replacement behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.