equinor / equinor/fusion-framework

app: AppConfigurator default client creation should not fall back to service discovery

Open Beginner friendly
#5,125 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

In `packages/modules/app/src/AppConfigurator.ts`, `_createHttpClient` falls back to creating a client via the `serviceDiscovery` module when the http provider hasn't configured one, with a comment noting this should be removed once the portal service is refactored.

```ts
// TODO - remove when refactor portal service!
/** resolve and create a client from discovery */
return await serviceDiscovery.createClient(serviceName);
```

Contributor guide

Open the contributing guide

Research direction

Open packages/modules/app/src/AppConfigurator.ts and read _createHttpClient, focusing on the serviceDiscovery fallback and its TODO comment. Confirm how the HTTP provider configuration is handled, then remove the fallback so an unconfigured provider no longer creates a discovery client; done means this path no longer calls serviceDiscovery.createClient.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.