equinor / equinor/fusion-framework

app: remove deprecated `key`/`name` getters from AppManifest transform

Open Beginner friendly
#5,124 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

In `packages/modules/app/src/AppClient.ts`, `ApplicationSchema`'s `transform` adds backwards-compatible `key` and `name` getters (aliasing `appKey`/`displayName`) marked as deprecated TODOs. Remove these once consumers have migrated to the non-deprecated properties.

```ts
// TODO: remove deprecated appKey
get key() {
return props.appKey;
},
// TODO: remove deprecated name
get name() {
return props.displayName;
},
```

Contributor guide

Open the contributing guide

Research direction

Open packages/modules/app/src/AppClient.ts and inspect ApplicationSchema's transform, then search the repository for consumers of the deprecated key and name getters. Done means the backwards-compatible getters are removed while appKey and displayName remain available; run the relevant package checks if identified in the repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.