equinor / equinor/fusion-framework
Remove `any` from enableModule's configurator parameter type
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 10
- Avg merge
- 19h 40m
- Merged PRs (30d)
- 150
Description
## Context
`enableModule` in `packages/modules/msal-node/src/enable-module.ts` currently types the `configurator` parameter as `any`:
```ts
export const enableModule = (
// biome-ignore lint/suspicious/noExplicitAny: @todo -remove when types sorted in provider interface
configurator: IModulesConfigurator,
configure: IModuleConfigurator['configure'],
) => {
```
## Task
Sort out the generic type parameters on `IModulesConfigurator` for the provider interface so `enableModule` no longer needs `any`.
## Acceptance criteria
- [ ] `enableModule`'s `configurator` parameter uses concrete generic types instead of `any`
Contributor guide
Research direction
Start in packages/modules/msal-node/src/enable-module.ts and locate the definition of IModulesConfigurator and its provider interface. Trace the generic parameters used by the configurator and the MsalNodeModule configure entry point, then run the package's type checks. Done means enableModule's configurator parameter uses concrete generic types and no longer needs any.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100