equinor / equinor/fusion-framework

Consider including app display name directly on bookmark object

Open
#5,091 0 comments 0 reactions 0 assignees View on GitHub
module:bookmark tech-debt
Dominant language
TypeScript
Stars
10
Forks
10
Avg merge
19h 40m
Merged PRs (30d)
150

Description

## Context

In `packages/react/components/bookmark/src/components/edit-bookmark/EditBookmark.tsx`, the app display name is resolved client-side via `useFrameworkModule('app').getAppManifest(bookmark.appKey)`:

```ts
// TODO - this should be on the bookmark object
const appProvider = useFrameworkModule('app');
const { value: appName } = useObservableState(
useMemo(
() => (bookmark && appProvider ? appProvider.getAppManifest(bookmark.appKey) : of(undefined)),
[appProvider, bookmark],
),
);
```

## Task

Investigate whether the bookmark's app display name can be included directly on the bookmark object (server-side), removing the need for this extra client-side manifest lookup.

## Acceptance criteria

- [ ] Either the bookmark object includes the app name, and this lookup is removed, or the reasoning for keeping the lookup is documented

Contributor guide

Open the contributing guide

Research direction

Start in packages/react/components/bookmark/src/components/edit-bookmark/EditBookmark.tsx, reading the TODO and the app manifest lookup. Trace where the bookmark object is produced and whether its server-side shape can carry the app display name. Done means either the lookup is removed because the bookmark supplies the name, or the decision to keep it is documented with its reasoning.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
full-stack
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.