equinor / equinor/ert

Evaluating `AHM_ANALYSIS` - deprecate, fix, or something else?

Open
#7,019 1 comment 0 reactions 0 assignees View on GitHub
needs-discussion
Dominant language
Python
Stars
161
Forks
140
Avg merge
2d 1h
Merged PRs (30d)
138

Description

The `AHM_ANALYSIS` is somewhat broken in that it consumes a lot of memory.
See the following issues for details:

Old issue discussing memory issues that are still prevalent:
- https://github.com/equinor/semeio/issues/318

Newer reports of memory issue:
- https://github.com/equinor/fmu-drogon/issues/11

The idea of `AHM_ANALYSIS` might be good and parts of it can perhaps be of use in the new `Analysis report`.

**Questions:**
- Should we just deprecate and delete it?
- Should we put in the effort to understand it, re-factor, etc.?
- Should this be done as part of the `Analysis report` milestone?

## What does `AHM_ANALYSIS` do?

The code itself is documented in this docstring:
https://github.com/equinor/semeio/blob/aa6107916e0cb1ea09301c093508600ec573bbbc/src/semeio/workflows/ahm_analysis/ahmanalysis.py#L19-L57

There's also this wiki entry:
https://wiki.equinor.com/wiki/FMU_drogon/AHM_ensemble_analytics

## Is it in use?

I searched the logs and there seems to be a tiny bit of usage:

![image](https://github.com/equinor/ert/assets/45088507/083c9737-1d53-4ad8-80c9-2e8fd2c5f8d6)

Note that it is required to create input for the `AssistedHistoryMatchingAnalysis` plugin in `webviz-subsurface`, but we don't know if this is in use.
The original author of both the workflow and webviz plugin has left the company.

## Other issues related to `AHM_ANALYSIS`:

- https://github.com/equinor/semeio/issues/498

Contributor guide

Open the contributing guide

Research direction

Start with the docstring in src/semeio/workflows/ahm_analysis/ahmanalysis.py and review the linked semeio, fmu-drogon, and semeio issues. Check the reported memory problems and current usage, including the AssistedHistoryMatchingAnalysis plugin dependency. Done means reaching and documenting a decision to deprecate, fix, or otherwise handle AHM_ANALYSIS.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.