equinor / equinor/ert

Make obs validations/mutations against response configs more explicit

Open
#12,822 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
161
Forks
141
Avg merge
2d 4h
Merged PRs (30d)
138

Description

These are currently embedded into the dataframe creation logic, but should be split out and made explicit.

* Prefer doing mutations of response configs based on observations declarations instead of dataframes/dataframe creations.
* Prefer doing validations of obs configs based on response configs outside of dataframe creation, but rather closer to _observations.py

Contributor guide

Open the contributing guide

Research direction

Start by locating the dataframe creation logic and read _observations.py to trace where observation declarations mutate response configs and where response configs validate observation configs. Separate these responsibilities from dataframe creation and place them near the observations logic; done means both validations and mutations follow the issue's stated configuration relationships.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.