equinor / equinor/TimeSeriesAnalysis
PidIdentifier should ideally rely only of FitScore to select among candidate models.
Open
known-limitation
- Dominant language
- C#
- Stars
- 22
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
PidIdentifier.IsFirstModelBetterThanSecondModel needs to consider both FitScore and RsqDiff for unit tests to pass.
If this method only considers FitScore, then DistStep_WNoise_Downsampled_KpAndTiEstimatedOk and SetpointStep_WNoise_Downsampled_KpAndTiEstimatedOk dont seem to converge to their best estimates.
Contributor guide
Assessment
This issue has not been assessed yet.