equinix-labs / equinix-labs/otel-cli

OTLP partial acceptance and rejected spans needs testing

Open
#268 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

testing
Dominant language
Go
Stars
718
Forks
59
PR merge metrics
No merged PRs in 30d

Description

I'm going to merge #266 as it is. That the fix is needed means there's a testing gap.

[ ] augment otlpserver and main_test.go to simulate partial accepts and rejections
[ ] write some tests for this

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the fix being merged in #266, then inspect the otlpserver code and main_test.go. Add tests that simulate partial acceptance and rejected spans, and verify the resulting behavior; the issue is complete when both cases are covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, observability, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.