epezent / epezent/implot

[Feature] A more capable skipper

Open
#698 4 comments 1 reaction 1 assignee Claimed by @EtienneParmentier View on GitHub
prio:medium status:review type:feat
Dominant language
C++
Stars
6.2k
Forks
693
PR merge metrics
No merged PRs in 30d

Description

**Context**
I am drawing a special kind of oscilloscope that is synchronized with the phase of my FM synthesizer.
While it make sense for me to draw lines between points that are near in phase; when my oscillator resets to zero it does not make sense to draw a line. Here is a screenshot with the offending lines:

Image

**Feature description**
I want to control which line segments should be skipped with a generic callback, like in ```ImPlot::PlotLineG```. I believe this is the most flexible approach. I could also add a flag but the behaviour would be very specific to my usecase.
I believe I have the bandwith and the skill to make a pull request, but I would like your opinion on the way to do this because I don't want to lose time on a design that would be rejected. For example, should I also implement this feature for other types of plots ?

I believe making yet another RendererLineXXX class is the way to go ?
Edit: I made a PR with my design: #699

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.