epam / epam/Indigo

Need to make a transition fo ObjPool<int> to std::vector<int> migration.

Open
#3,793 0 comments 0 reactions 1 assignee Claimed by @NikolaiBalabanov View on GitHub
c++ Core Indigo Service
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

As part of the ObjPool deprectation it's required to replace ObjPool with std::vector, since it is not used as an object pool here, but as a sparse set of small ints.

--
## Acceptance criteria

- [ ] Characterization test on master pinning current behavior of
`getTemplateAtomAttachmentPoint()` / `getTemplateAtomAttachmentPointById()` /
`getTemplateAtomAttachmentPointsCount()` **before and after** in the `remove()`
`postload`-branch; outcome documented, fixed by tests suits.
- [ ] No `ObjPool` in a `base_molecule.h` persists.
- [ ] Signature of `getTemplateAtomAttachmentPointIdxs` updated.
- [ ] All 8 sites sparse iteration converted;
- [ ] Verified no dangling references to outer-vector elements across `resize()`.
- [ ] `obj_pool.h` - deleted as last step of migration.
---

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.