epam / epam/Indigo

Layout and Save to RXN/RDF works not correctly when Multi-Tailed Arrow is on canvas without elements near tails or head, If no elements are near multi-tailed arrow, layout action should consider it as empty elements

Open
#2,424 0 comments 0 reactions 1 assignee Claimed by @even1024 View on GitHub
Cascade reactions Export to RXN Layout MMPK Priority: High
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

**Steps to Reproduce Case 1**
1. Add Multi-Tailed Arrow with 3 tails:
![image](https://github.com/user-attachments/assets/08799244-b52c-4515-a772-9354b2273578)
2. Click on Layout

**Actual behavior**
- Arrow appears, Multi-Tailed Arrow is moved:
![image](https://github.com/user-attachments/assets/37babe17-d42a-4585-9251-1613235f3dfe)

**Expected behavior**
- Multi-Tailed arrow is moved to the center and size is changed to default for indigo (https://github.com/epam/Indigo/issues/2309)

3. Click one more time - multi-tailed arrow disappears, the arrow is moved to the center
![image](https://github.com/user-attachments/assets/cb82ee94-8f05-4a13-9e22-f5660e823867)

**Steps to Reproduce Case 2**
1. Add Multi-Tailed Arrow with 3 tails, add benzene rings, leave two tails without elements:
![image](https://github.com/user-attachments/assets/13c986a8-cf3f-44b7-9340-f53a3815b99b)
2. Click on Layout

**Actual behavior**
- Arrow appears, Multi-Tailed Arrow is moved:
![image](https://github.com/user-attachments/assets/af591c7d-ccfb-4fcf-9aa1-ce2f94fec40c)

**Expected behavior**
- Multi-Tailed arrow is moved to the center with elements and size of arrow is changed to default for indigo:
![image](https://github.com/user-attachments/assets/adbe40ab-c503-4640-a021-26c473cbb842)

3. Click one more time - multi-tailed arrow disappears, the arrow is moved to the center

**Steps to Reproduce Case 3**
1. Add Multi-Tailed Arrow with 3 tails, add elements and single arrow:
![image](https://github.com/user-attachments/assets/4cf788f2-b62b-479f-b1c3-2ee65c4b519b)
2. Click on Layout

**Actual behavior**
- Multi-Tailed Arrow disappear:
![image](https://github.com/user-attachments/assets/4a122a61-a8f8-4306-8477-fa1e9960a61a)

**Expected behavior**
- Multi-Tailed arrow is moved to the center with elements and size of arrow is changed to default for indigo

**Environment details**
- Tested on CI-CD 2237-detect-pathway SA environment
- Ketcher [Version 2.25.0-rc.2] Build at 2024-09-24; 02:30:35
- Indigo Version 1.25.0-dev.1.58-ga966745f-wasm32-wasm-clang-12.0.0
- Windows 11 Enterprise
- Chrome Version 129.0.6668.59 (Official Build) (64-bit)

**Notes**
- Test cases are added to xls for RDF, RXN and Layout and should be automated
- This fix is affected save to RXN/RDF as well, for example a case with Cascade reaction:
1. Add a reaction from the KET file:
[1-cascade-branches-ordering.zip](https://github.com/user-attachments/files/17247272/1-cascade-branches-ordering.zip)
2. Add an additional tail to any multi-tailed arrow:
![image](https://github.com/user-attachments/assets/0c7b0b21-883d-4c2e-a4ee-1a11d384ed5d)
3. Click on save to RDF - there is a 6:4 reaction that's not correct, all elements shouldn't be united:
![image](https://github.com/user-attachments/assets/2e14dd9b-1286-45a2-9d97-eb195fe9b5e0)
- Issue is detected during exploratory testing of Import/Export of Multi-Tailed Arrow in cascade reactions - https://github.com/epam/Indigo/issues/2236

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.