epam / epam/Indigo

Unclear and inconsistent behavior in displaying different types of arrows when importing from PPTX(CDX) file

Open
#2,326 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

**Summary**
The expected behavior for the displaying different types of arrows after the import from PPTX is not documented. However, based on a comment https://github.com/epam/Indigo/issues/2232#issuecomment-2334398454, it was found that the current implementation differs in ways that were discussed but not formally documented.

**Steps to Reproduce**
1. Click the «Open... button (Ctrl+O)»
2. Select open from file
3. Select file: [ARROWS.pptx](https://github.com/user-attachments/files/16910446/ARROWS.pptx)
4. Select Structure 2, which corresponds to page 2

**Expected behavior**
The expected behavior is not formally documented. However, based on a comment https://github.com/epam/Indigo/issues/2232#issuecomment-2334398454, it is clear that the arrow conversion logic should be implemented as follows (for all other types, option 1 should be selected):
![image](https://github.com/user-attachments/assets/f6bf69ec-66af-42c6-9d3f-9255f3eafab0)

**Actual behavior**
An incorrect conversion of arrow type 2 occurs, you can see the actual and expected results in the screenshot:
![image](https://github.com/user-attachments/assets/10ca478e-ab84-49ea-943c-5cb657ecd5cc)

In addition, there is no conversion to option 1 for all other types of arrows:
![image](https://github.com/user-attachments/assets/18d9332a-e125-474b-bc6e-612dfe013767)

**Environment details:**
Ketcher Version: 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
Indigo Version: 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
Chrome Version: Version 128.0.6613.113 (Official Build) (64-bit)
Windows 11 Enterprise

**Additional context**
Issue found while testing https://github.com/epam/Indigo/issues/2232

Contributor guide

No contributing guide indexed for this repository

Research direction

Open the supplied ARROWS.pptx through Open (Ctrl+O) and reproduce the issue using Structure 2. Compare the result with the conversion behavior described in issue #2232 and verify that arrow type 2 and the remaining arrow types match the expected mapping shown in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.