epam / epam/Indigo

Adding Any Atom to the canvas make sulfur (S) valence equal 3 in aromatic ring

Open
#1,838 0 comments 0 reactions 0 assignees View on GitHub
query features phase II
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

**Steps to Reproduce**
1. Put on the canvas following SMILES: `S1=SS=SS=S1`
2. Press Aromatize button
![image](https://github.com/epam/Indigo/assets/26869421/d4744a39-1713-4844-8079-2bec9968c076)
3. Press Add/Remove implicit hydrogens button to fold hydrogens
![image](https://github.com/epam/Indigo/assets/26869421/14c20165-046d-4e03-b87a-23c29ef8710a)
4. Press Add/Remove implicit hydrogens button to unfold hydrogens
![image](https://github.com/epam/Indigo/assets/26869421/d4744a39-1713-4844-8079-2bec9968c076)
5. Add Any Atom to the canvas
![image](https://github.com/epam/Indigo/assets/26869421/eacde062-1f49-4e19-93ce-70b842a9b1b3)
6. Press Add/Remove implicit hydrogens button to fold hydrogens
![image](https://github.com/epam/Indigo/assets/26869421/193794fd-8194-4982-8358-1faa62a9ccb0)
7. Press Add/Remove implicit hydrogens button to unfold hydrogens

**Actual behavior**
Valency turns to 3
![image](https://github.com/epam/Indigo/assets/26869421/ebfa8605-9609-4dc0-94ac-d5102e595b92)

**Expected behavior**
Valency remain 4
![image](https://github.com/epam/Indigo/assets/26869421/d4744a39-1713-4844-8079-2bec9968c076)

**Ketcher version** [e.g. v2.4.2].
- Indigo Toolkit Version 1.18.0.0-g73c32dec3-wasm32-wasm-clang-12.0.0
- Ketcher Version 2.19.0-rc.2 Build at 2024-03-11; 12:30:30
- Chrome Version Version 122.0.6261.112 (Official Build) (64-bit)
- Win10
- Issue found while testing https://github.com/epam/Indigo/issues/1436

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the reported SMILES workflow in Ketcher with Indigo Toolkit 1.18.0.0-wasm32: aromatize the ring, fold and unfold implicit hydrogens, add Any Atom, and repeat the hydrogen toggle. Done means sulfur valency remains 4 rather than changing to 3 after the Any Atom operation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, wasm
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.