epam / epam/Indigo

Add/Remove hydrogens wipes out custom query features and move some of them to Query specific

Open
#1,752 1 comment 0 reactions 0 assignees View on GitHub
Hydrogens Priority: Medium Query features
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

**Describe the bug**
Add/Remove hydrogens wipes out custom query features and move some of them to Query specific

**Steps to Reproduce**
1. Load from file: [AddRemove hydrogens wipes out custom query features and move some of them to Query specific.zip](https://github.com/epam/Indigo/files/14433847/AddRemove.hydrogens.wipes.out.custom.query.features.and.move.some.of.them.to.Query.specific.zip)
2. Press Add/Remove explicit hydrogens button
![image](https://github.com/epam/Indigo/assets/26869421/0f7e6e00-4328-4dcd-8c45-c2b447b89440)

**Actual behavior**
Add/Remove hydrogens wipes out custom query features and move some of them to Query specific
![image](https://github.com/epam/Indigo/assets/26869421/82706f98-67c5-4bf1-a240-5abec9db5171)

**Expected behavior**
Custom query features remain in place

**Environment details (please complete the following information):**
- Ketcher Version 2.18.0-rc.8 Build at 2024-02-22; 17:34:35
- Indigo Toolkit Version 1.18.0-rc.8.0-g85a393c7c-x86_64-linux-gnu-11.2.1
- Firefox Version 123.0 (64-bit)
- Win10
- Issue found while testing https://github.com/epam/Indigo/issues/1589

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue with the attached ZIP and the Add/Remove explicit hydrogens button in the reported Ketcher/Indigo versions. Trace the hydrogens operation and its handling of custom query features; done means those features remain in place after the operation, rather than being wiped out or moved to Query specific.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.