epam / epam/Indigo

Bingo PgSQL checkMolecule function doesn't check implicit hydrogen count

Open
#115 0 comments 0 reactions 0 assignees View on GitHub
Bingo
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

This is a minor issue, but when Bingo is indexing molecules, I think it's the cmf_saver that checks that implicit hydrogen count is sane, i.e. <=10.
The bingo.CheckMolecule() cartridge function however does not indicate any issues with these molecules as this is not one of its checks.
I expect most users will not have input that causes this issue :-p

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Bingo PostgreSQL cartridge implementation of bingo.CheckMolecule() and compare its validation with the cmf_saver check for implicit hydrogen counts. Confirm the expected limit from the issue, then identify the existing Bingo test entry point or add coverage where this behavior is tested. Done means CheckMolecule reports molecules whose implicit hydrogen count exceeds the accepted limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, postgresql
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.