epam / epam/Indigo

Bingo tanimoto similarity can be over 1?

Open
#112 2 comments 0 reactions 0 assignees View on GitHub
Bingo
Dominant language
C++
Stars
406
Forks
134
Avg merge
2d 11h
Merged PRs (30d)
24

Description

I'm using a version built from source on the 16th November 2017 against PostgreSQL 9.6.

`select count(*) from bingo.chemdata where smiles @ ('0.95', '1', 'S(C1C=CC(=C(C2=NC(C3=C(C(CCC)=NN3C)N2)=O)C=1)OCC)(N1CCN(C)CC1)(=O)=O', 'Tanimoto')::bingo.sim`
9
`select count(*) from bingo.chemdata where smiles @ ('0.95', '1.01', 'S(C1C=CC(=C(C2=NC(C3=C(C(CCC)=NN3C)N2)=O)C=1)OCC)(N1CCN(C)CC1)(=O)=O', 'Tanimoto')::bingo.sim`
14
`select count(*) from bingo.chemdata where smiles @ ('0.95', '1.02', 'S(C1C=CC(=C(C2=NC(C3=C(C(CCC)=NN3C)N2)=O)C=1)OCC)(N1CCN(C)CC1)(=O)=O', 'Tanimoto')::bingo.sim`
17
[the identical compound had a similarity somewhere between 1.01 and 1.02]

This behaviour did not exist in a version from ~2014.

Another minor bug is that if the upper bound on similarity is given as a null, this is interpreted as 0 rather than 1 (or perhaps a number greater than 1!) and hence the query is rejected.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.