envoyproxy / envoyproxy/toolshed

Add async logging for root logger in runner

Open
#389 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
12
Forks
24
Avg merge
6h 37m
Merged PRs (30d)
92

Description

When adding async logging it was not possible to add for the root logger as the flake8 module that is called in `envoy.code.check` uses `multiprocessing.pool` and the threadsafe queue that is used by default, does not work for that situation

Its likely that using a multiprocessing.queue would fix the problem, at the expensive of some perf, so it may be desirable to use a queue according to whether debug logging is set

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.