envoyproxy / envoyproxy/nighthawk
Mismatched type for fortio response
- Dominant language
- C++
- Stars
- 414
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Description
*Title*: *Mismatched type for fortio response causes failure in interconversion*
*Description*:
The message format in protobuff here https://github.com/envoyproxy/nighthawk/blob/f42add9bb5c71a5652db2f9471dda357b96d5ee2/api/client/transform/fortio.proto#L31 mismatches the expected datatype by fortio here https://github.com/fortio/fortio/blob/d2a2d42f4f17df4c09e608353546ebd0d443747d/periodic/periodic.go#L221 on the field `RequestedQPS`
This is causing Unmarshalling to fail while conversion from one to another.
*Reproduction steps*:
> Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.
>**Note**: If there are privacy concerns, sanitize the data prior to
sharing.
*Logs*:
>Include the Nighthawk logs.
>**Note**: If there are privacy concerns, sanitize the data prior to
sharing.
*Call Stack*:
> If the Envoy binary is crashing, a call stack is **required**.
Please refer to the [Bazel Stack trace documentation](https://github.com/envoyproxy/envoy/tree/master/bazel#stack-trace-symbol-resolution).
Contributor guide
Assessment
This issue has not been assessed yet.