envoyproxy / envoyproxy/nighthawk
Stop using deprecated mock method macros
- Dominant language
- C++
- Stars
- 414
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Description
When running fix_format, it will give a complaint like the following:
```
ERROR: From ./../nbperry-nighthawk/test/test_common/mock_stream.h
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:15: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:18: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:21: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:31: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:34: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:35: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:38: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:41: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:42: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
```
I considered this outside the scope of fixing formatting, but as a followup we should probably move to MOCK_METHOD.
Contributor guide
Assessment
This issue has not been assessed yet.