envoyproxy / envoyproxy/nighthawk

Finish extracting time-tracking and dynamic-delay filters from ResponseOptions proto

Open
#859 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

After https://github.com/envoyproxy/nighthawk/pull/855/ is pushed through, these two filters now have their own configuration for starting up the filters, without any internal references to ResponseOptions.proto. However, the header override api still requires their fields to exist on ResponseOptions.proto, because the ResponseOptions proto is what is passed through the `x-nighthawk-test-server-config` header.

In order to move off this, we should:
1. Introduce three separate headers, one for each configuration (or one new header with three subsets of configuration). The current header will then become a legacy header and will issue warnings
2. Introduce a flag that makes only the new headers work
3. Remove the old header completely.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.