envoyproxy / envoyproxy/nighthawk

Fix bugprone-narrowing-conversions reported by clang-tidy

Open
#750 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

Clang-tidy started reporting a couple of `bugprone-narrowing-conversions`. The check was disabled to allow an Envoy update to proceed. The code issues should be fixed and the check re-enabled.

Check disabled in [.clang-tidy](https://github.com/envoyproxy/nighthawk/blob/main/.clang-tidy).

The reported issues are in [this CI log](https://github.com/envoyproxy/nighthawk/files/7283496/reported_issues.txt).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.