envoyproxy / envoyproxy/nighthawk

Make the SignalHandler class implementation easier to follow

Open
#603 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

The SignalHandler class could use a little love (code level docs, member renaming for clarity), it requires too much brainpower to follow as it stands. @eric846's [review comment](https://github.com/envoyproxy/nighthawk/pull/602/files#r554281486) looks like a great starting point for a class level description.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.