envoyproxy / envoyproxy/nighthawk
Unit tests for computeFirstWorkerStart() and computeInterWorkerDelay()
Open
enhancement
tech-debt
- Dominant language
- C++
- Stars
- 414
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Description
In https://github.com/envoyproxy/nighthawk/pull/573 two methods have been extracted to avoid the `dynamic_delay` extension from growing more complex:
1. `ProcessImpl::computeFirstWorkerStart()`
2. `ProcessImpl::computeInterWorkerDelay()`
While these are covered in tests indirectly, it would be good to directly unit-test those
to ensure their input/output is correct.
Contributor guide
Assessment
This issue has not been assessed yet.