envoyproxy / envoyproxy/nighthawk

HttpTestServerDecoderFilterTest.HeaderMerge tests too many things

Open
#559 0 comments 0 reactions 0 assignees View on GitHub
good first issue tech-debt
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

`HttpTestServerDecoderFilterTest.HeaderMerge` has grown too large, and it would be good to split
it up in a couple of smaller tests. As it stands, it tests too many things as a single unit test, and we can
make things easier to understand and also produce more helpful test failures by splitting it up.

This came up in https://github.com/envoyproxy/nighthawk/pull/512/files/79b25083d665124d713f53c6794f9a76dba9df21#diff-f3f9ecf5caebc75351abab7a618f0405 but as it is pre-existing, tracking this separately.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.