envoyproxy / envoyproxy/nighthawk

Optimise tracking of deferred timings in DelegatingRateLimiterImpl request-release timing

Open
#555 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

As of https://github.com/envoyproxy/nighthawk/pull/552, the `DelegatingRateLimiter` implementation buffers request-release timings from its inner rate limiter.
Today it uses a sorted `std::list` to accomplish this, but there are probably more efficient means to pull
this off when there are many timings to track.

Context: https://github.com/envoyproxy/nighthawk/pull/552/commits/131d2e04c141d8ff37ccb8a316d5639f828db1e1#r495628578

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.