envoyproxy / envoyproxy/nighthawk
Fortio output transform test: minimize gold files
- Dominant language
- C++
- Stars
- 414
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Description
In our tests that ensure we are able to transform Nighthawk's native output format to Fortio's,
we use rather arbitrary and large sample data, see [input](https://github.com/envoyproxy/nighthawk/blob/master/test/test_data/output_formatter.medium.proto.gold) and the corresponding
[output](https://github.com/envoyproxy/nighthawk/blob/master/test/test_data/output_formatter.medium.fortio.gold).
In #534 we are more or less forced to propagate this into yet a new gold file, which by implication, also needs to be large and arbitrary.
Long gold files make it hard for the reader to figure out which portions actually are relevant to tests and which are just noise. It would be good to could cut these down to the minimum required to test this the expected behaviours?
Context: https://github.com/envoyproxy/nighthawk/pull/534#discussion_r489936479
Contributor guide
Assessment
This issue has not been assessed yet.