envoyproxy / envoyproxy/nighthawk

check format / fix format: include ordering for unspecified directories

Open
#509 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

When adding an include from a directory not explicitly specified in our check_format scrips,
the automatic formatting fixing may produce output that gets flagged by the formatting check.
That's less then ideal. Ideally they would line up when there's no explicit ordering specified.

Context: https://github.com/envoyproxy/nighthawk/pull/493#pullrequestreview-476390192

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.