envoyproxy / envoyproxy/nighthawk

Clarify function names that create TypedExtensionConfigs

Open
#507 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

For example `MakeFakeInputVariableSetterConfig()` doesn't return a `FakeInputVariableSetterConfig`, it returns a `TypedExtensionConfig` with a `FakeInputVariableSetterConfig` packed into an `Any` in the `typed_config` field. It should be renamed `MakeFakeInputVariableSetterTypedExtensionConfig()`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.