envoyproxy / envoyproxy/nighthawk

Benchmark framework docker flow should not run as root

Open
#383 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

While review feedback was in process for #337, Envoy landed a breaking change the docker images it pushes, as they no longer run as root by default. To resolve, this TODO was left in code comments:

```python
# As of https://github.com/envoyproxy/envoy/commit/e8a2d1e24dc9a0da5273442204ec3cdfad1e7ca8
# we need to have ENVOY_UID=0 in the environment, or this will break on docker runs, as Envoy
# will not be able to read the configuration files we stub here in docker runs.
```

Ideally we follow up with a change that would not make us need `ENVOY_UID=0`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.