envoyproxy / envoyproxy/nighthawk

counter-based termination conditions may get slightly exceeded

Open
#356 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

Consider a configured threshold as follows:

```bash
--termination-predicate benchmark.http_2xx:99
```

The way this is implemented, when the client stops, one would expect to see `benchmark.http_2xx` at `100` when the client finishes.

However, it looks like it is possible under certain conditions to have Nighthawk report a slightly higher number.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.