envoyproxy / envoyproxy/nighthawk

Enhanced termination predicates via CEL

Open
#201 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

In https://github.com/envoyproxy/nighthawk/pull/176 we landed the `termination-predicate` feature.
This allows configuration of simple chains of counter + thresholds combinations that will specify when and with which status an execution terminates by testing if thresholds are met.

However, during review @htuch mentioned [1] CEL (currently in use by Envoy in RBAC) as a potentially more powerful way to allow users to express more complex conditions. Leveraging CEL seems doable, and we could add it as a new `TerminationPredicate` implementation to make it co-exist with what we have today and stay backwards compatible.

Filing this issue to track this idea.

[1] https://github.com/envoyproxy/nighthawk/pull/176#discussion_r342899905

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.