envoyproxy / envoyproxy/nighthawk

Consider output restructuring

Open
#195 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

Nighthawk currently defines its output as follows:

```proto
message Result {
string name = 1;
repeated Statistic statistics = 2;
repeated Counter counters = 3;
}

message Output {
google.protobuf.Timestamp timestamp = 1;
nighthawk.client.CommandLineOptions options = 2;
re
```

Statistics and counters have an id property. Consumers may become reliant on a specific id to be emitted.

A concrete example arose in the PR that adds an output transform for Fortio's format.
That relies on a) the aggregated global results to be around, and b) the a statistic with id `benchmark_http_client.request_to_response`.

Context: https://github.com/envoyproxy/nighthawk/pull/168/files/932814f6ee21ae4e2670fecfb42f80bbfd623afb#r341337505

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.